-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stac-browser #168
base: main
Are you sure you want to change the base?
Add stac-browser #168
Conversation
Hello, this is my first contribuiton to k8s-eoapi. Please let me know if there is anything I can improve or if you prefer the alternative approach with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for this PR! ❤️
Apologies for any inconvenience, but I’m not in favor of pulling the stac-browser image from a personal registry. I think we should stick to using the upstream maintainer's image. As for the prefix issue, we’ll need to address that in another way.
replicaCount: 1 | ||
image: | ||
# we use a custom image that overrides pathPrefix value | ||
name: ghcr.io/alekzvik/stac-browser-prefix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is good to pull a custom made image from a personal source.
@@ -16,6 +16,7 @@ data: | |||
<li><a href="/raster" target="_blank" rel="noopener noreferrer">/raster</a></li> | |||
<li><a href="/vector" target="_blank" rel="noopener noreferrer">/vector</a></li> | |||
<li><a href="/stac" target="_blank" rel="noopener noreferrer">/stac</a></li> | |||
<li><a href="/browser/" target="_blank" rel="noopener noreferrer">/browser</a></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me the term browser
seems to general. I would prefer to have this under /stac/...
somehow, or find a more explicit wording. The boring approach would be stac-browser
;
A very beautiful would be to integrate it on an endpoint level, like here. But this is a different direction and out-of-scope for this PR/approach.
What I am changing
I am adding a STAC Browser as an additional service.
How I did it
I am using a custom image due to complications described here
The custom image is built on CRON once daily if there are changes.
Alternatives
Another alternative is to avoid a custom image and do all the work in the
initContainer
. We spawn aninitContainer
withnode
that checks out the git repo on a tag, installs dependencies, builds thestac-browser
, and puts the static files in a shared volume. The main container would be nginx which serves the data from the mounted volume.Pros:
Cons:
npm install
&npm build
take a long timeNotes
values.yaml
that the preferred way to deploy the STAC browser would not be with k8s&helm, but maybe there is a better way to convey this to users./browser
URL routing (without the trailing slash) and I have not identified the source yet.How you can test it
helm update --install ...
and one more service appears in the list of static services.The URL is
/browser/
, it will point to the stac endpoint exposed at/stac
Related Issues
Closes #62